Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 商品・商品コード・商品カテゴリでの顧客検索を改善 #313

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] 商品・商品コード・商品カテゴリでの顧客検索を改善 #313

wants to merge 3 commits into from

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Oct 3, 2019 •
edited
Loading

  • 商品関連の検索をする場合, 先に絞り込んだ結果を INNER JOIN するよう修正
  • 注文件数が3〜4万件くらいになると効果を発揮

TODO

  • SC_CustomerList のテスト作成
  • PostgreSQL/MySQL のベンチマークと EXPLAIN
  • 他の機能や決済系プラグインの影響調査

@nanasess
商品・商品コード・商品カテゴリでの顧客検索を改善
1237bb2 
- 商品関連の検索をする場合, 先に絞り込んだ結果を INNER JOIN するよう修正
@coveralls
Copy link

coveralls commented Oct 3, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.9%) to 51.646% when pulling 7b05fd6 on nanasess:improve/customer-search into 8877c7f on EC-CUBE:improve/php7.

@chihiro-adachi chihiro-adachi added this to the 2.17.0 milestone Oct 6, 2019
@kiy0taka kiy0taka changed the base branch from improve/php7 to master October 23, 2019 01:40
@chihiro-adachi chihiro-adachi modified the milestones: 2.17.0, 2.17.1 Oct 29, 2019
@ryo-endo ryo-endo modified the milestones: 2.17.1, 2.17.2 Jun 29, 2020
@nanasess nanasess marked this pull request as draft June 2, 2021 04:22
@nanasess nanasess mentioned this pull request Oct 7, 2021
Open
3 tasks
@nanasess nanasess modified the milestones: 2.17.2, 2.17.3 Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.18(仮)
Development

Successfully merging this pull request may close these issues.
4 participants
@nanasess @coveralls @chihiro-adachi @ryo-endo