Skip to content

[Fix] 리뷰 작성 후 리뷰 리스트 화면에 돌아왔을때 방금 쓴 리뷰가 없는 문제를 해결해요 #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HI-JIN2 merged 2 commits into from
Mar 9, 2026
Merged

[Fix] 리뷰 작성 후 리뷰 리스트 화면에 돌아왔을때 방금 쓴 리뷰가 없는 문제를 해결해요 #493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f5e127
fix: review list refreshes after write
HI-JIN2 Mar 5, 2026
de1cfa2
fix: refresh review list after write
HI-JIN2 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ...rc/main/java/com/eatssu/android/presentation/cafeteria/review/list/ReviewListViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ import com.eatssu.common.enums.MenuType
import com.eatssu.common.enums.ToastType
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.channels.BufferOverflow
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.filterNotNull
import kotlinx.coroutines.flow.flatMapLatest
import kotlinx.coroutines.launch
import javax.inject.Inject
Expand All @@ -41,21 +41,24 @@ class ReviewListViewModel @Inject constructor(
private val _uiEvent: MutableSharedFlow<UiEvent> = MutableSharedFlow()
val uiEvent = _uiEvent.asSharedFlow()

private val _loadParams = MutableStateFlow<Pair<MenuType, Long>?>(null)
private val _loadParams = MutableSharedFlow<Pair<MenuType, Long>>(
replay = 1,
extraBufferCapacity = 1,
onBufferOverflow = BufferOverflow.DROP_OLDEST,
)

@OptIn(ExperimentalCoroutinesApi::class)
val reviewPagingData: Flow<PagingData<Review>> = _loadParams
.filterNotNull()
.flatMapLatest { (menuType, itemId) ->
getReviewListPagedUseCase(menuType, itemId)
}
.cachedIn(viewModelScope)

fun getReview(menuType: MenuType, itemId: Long) {
// 파라미터 업데이트 시 페이징 흐름 트리거
// StateFlow는 동일한 값으로 설정되어도 업데이트되지 않으므로 별도의 체크 불필요
_loadParams.value = menuType to itemId
// 동일 파라미터로 다시 진입(작성/수정 후 popBackStack)해도
// 항상 페이징 소스를 새로 만들 수 있도록 SharedFlow로 트리거한다.
_loadParams.tryEmit(menuType to itemId)

viewModelScope.launch {
loadReviewInfo(menuType, itemId)
}
Expand Down Expand Up @@ -94,10 +97,8 @@ class ReviewListViewModel @Inject constructor(
_uiEvent.emit(ReviewListEvent.ReviewDeleted)

// 정보 갱신
val currentParams = _loadParams.value
if (currentParams != null) {
loadReviewInfo(currentParams.first, currentParams.second)
}
val currentParams = _loadParams.replayCache.lastOrNull()
if (currentParams != null) loadReviewInfo(currentParams.first, currentParams.second)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

가독성과 향후 유지보수성을 위해 if 문에 중괄호 {}를 사용하는 것을 권장합니다. 이렇게 하면 나중에 if 블록에 코드를 추가할 때 발생할 수 있는 실수를 방지할 수 있습니다.

            if (currentParams != null) {
                loadReviewInfo(currentParams.first, currentParams.second)
            }

}
}
}
Expand Down