Skip to content

[Fix] MenuType enum의 llegalArgumentException을 예방합니다 #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeraSite merged 4 commits into from
Mar 3, 2026
Merged

[Fix] MenuType enum의 llegalArgumentException을 예방합니다 #486

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54a9d1a
fix(review): Handle null or invalid MenuType gracefully in ReviewComp…
HI-JIN2 Mar 3, 2026
e2c9e69
feat(review): Add ErrorScreen with Preview and Crashlytics logging fo…
HI-JIN2 Mar 3, 2026
9d07eda
fix(review): Move getIntents() before setContent to prevent null Menu…
HI-JIN2 Mar 3, 2026
602064f
refactor: enum 계산 개선
PeraSite Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions app/src/main/java/com/eatssu/android/presentation/cafeteria/review/ReviewComposeActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.navigation.compose.rememberNavController
import com.eatssu.android.presentation.cafeteria.review.ReviewNav
import com.eatssu.common.enums.MenuType
import com.eatssu.design_system.theme.EatssuTheme
import dagger.hilt.android.AndroidEntryPoint
Expand All @@ -13,7 +14,7 @@ import kotlin.properties.Delegates
@AndroidEntryPoint
class ReviewComposeActivity : ComponentActivity() {

private lateinit var menuType: String
private var menuType: String? = null
private var itemId by Delegates.notNull<Long>()
private lateinit var itemName: String

Expand All @@ -23,20 +24,29 @@ class ReviewComposeActivity : ComponentActivity() {
EatssuTheme {
val navHostController = rememberNavController()

ReviewNav(
navHostController = navHostController,
menuType = MenuType.valueOf(menuType),
menuName = itemName,
id = itemId,
onExit = { finish() }
)
val parsedMenuType = runCatching {
if (menuType.isNullOrBlank()) null else MenuType.valueOf(menuType!!)
}.getOrNull()

parsedMenuType?.let { type ->
ReviewNav(
navHostController = navHostController,
menuType = type,
menuName = itemName,
id = itemId,
onExit = { finish() }
)
} ?: run {
Timber.e("Invalid or null MenuType received: \$menuType")
finish()
Comment thread
HI-JIN2 marked this conversation as resolved.
Outdated
}
Comment thread
HI-JIN2 marked this conversation as resolved.
Outdated
}
}
getIntents()
}

private fun getIntents() { //todo 추후 변경
menuType = intent.getStringExtra("menuType").toString()
menuType = intent.getStringExtra("menuType")
itemId = intent.getLongExtra("itemId", 0)
itemName = intent.getStringExtra("itemName").toString().replace(Regex("[\\[\\]]"), "")

Expand Down