This repository was archived by the owner on Jan 22, 2022. It is now read-only.
WSQ: Support transcoding IIOMetadata classes#7
Open
paulo-raca wants to merge 1 commit into
Open
Conversation
paulo-raca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WSQImageWriter currently crashes when transcoding image formats (e.g., JPEG -> WSQ) if we try to preserve the metadata, because we blindly try casting it to WSQMetadata.
This PT change the code uses
IIOMetadata.setFromTree()to populate a WSQMetadata instance from a generic metadata by inspecting the standard XML Tree.(The only metadata actually being copied are PPI and Bitrate, but the solution is generic)