Add non-blocking PACE links to simulation details#176
Merged
tomvothecoder merged 3 commits intoE3SM-Project:mainfrom May 5, 2026
Merged
Add non-blocking PACE links to simulation details#176tomvothecoder merged 3 commits intoE3SM-Project:mainfrom
tomvothecoder merged 3 commits intoE3SM-Project:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the non-blocking PACE-link flow requested in #173 by resolving a PACE experiment ID separately from the main simulation-details fetch, so the details page can render without waiting on PACE.
Changes:
- Adds a new backend
GET /api/v1/pace/resolveendpoint to look up a PACE experiment ID from a simulation execution ID. - Updates the simulation details page to request PACE resolution asynchronously and build either a direct experiment link or a fallback search link.
- Adds UI states in the Performance section for in-progress and fallback PACE-link behavior, plus backend tests for the new resolver.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/features/simulations/SimulationDetailsPage.tsx |
Triggers async PACE resolution and passes link/status props into the details view. |
frontend/src/features/simulations/components/SimulationDetailsView.tsx |
Renders the new PACE link, spinner, and tooltip states in the Performance section. |
frontend/src/features/simulations/api/api.ts |
Adds the frontend API client/types for /pace/resolve. |
backend/tests/features/pace/test_api.py |
Adds backend tests for the resolver’s success, validation, and fallback paths. |
backend/app/main.py |
Registers the new PACE router in the FastAPI app. |
backend/app/features/pace/api.py |
Implements the PACE resolution endpoint and upstream lookup/parsing logic. |
backend/app/features/pace/__init__.py |
Adds the new backend feature package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds non-blocking PACE links to the simulation details page.
GET /api/v1/pace/resolve?execution_id=...to resolve a PACE experiment ID with a 5.0s timeoutSearch in PACEimmediately whenexecutionIdexists, then upgrades toOpen in PACEif resolution succeedsChecklist
Deployment Notes (if any)