Include Omega fields needed for p* coordinate in initial conditions#573
Draft
xylar wants to merge 3 commits intoE3SM-Project:mainfrom
Draft
Include Omega fields needed for p* coordinate in initial conditions#573xylar wants to merge 3 commits intoE3SM-Project:mainfrom
xylar wants to merge 3 commits intoE3SM-Project:mainfrom
Conversation
This is needed so we can compute the reference pseudo-thickness for p* from `restingThickness`. This merge also adds support for multiple iterations when computing pseudo-thickness using TEOS-10.
94a9c56 to
0e8f636
Compare
Collaborator
Author
|
While this should work now, it won't actually be useful until we bring in the p* vertical coordinate from Omega. |
Collaborator
Author
|
Seems to work in that I'm seeing bit-for-bit results with the |
cbegeman
reviewed
May 5, 2026
| if self.model == 'omega' and config is not None: | ||
| mpas_to_omega_vars = { | ||
| 'layerThickness': 'PseudoThickness', | ||
| 'restingThickness': 'RefLayerThickness', |
Collaborator
There was a problem hiding this comment.
Are there plans to rename the Polaris variable RefPseudoThickness?
Collaborator
There was a problem hiding this comment.
Seems that you have that in the pseudo-thickness rename PR. I'm cool with you merging this now and we can make that change after the pseudo-thickness PR is merged.
Collaborator
Author
There was a problem hiding this comment.
Yes, that's the plan.
0e8f636 to
ffdaf77
Compare
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR maps
vertCoordMovementWeightstoVertCoordMovementWeightsin Omega and addsRefLayerThicknessas the reference pseudo-thickness computed fromrestingThicknessin Omega initial conditions.We also add support for multiple iterations for computing pseudo-thickness from geometric thickness if the EOS is TEOS-10. The default is 6 iterations, which has been found to be sufficient to achieve machine precision in the horiz_press_grad test.
Checklist
Testingcomment in the PR documents testing used to verify the changes