Take advantage of xarray's decode_times for Omega's time variable conversion#570
Merged
cbegeman merged 5 commits intoE3SM-Project:mainfrom May 4, 2026
Merged
Conversation
…onds ... and uses the default start time for MPAS-O and Omega
5a009f2 to
be04b9d
Compare
Collaborator
Author
TestingThe full omega_pr test suite ran successfully. Some of the baseline comparisons failed because I used an older test instead of re-running with main. |
Collaborator
Author
|
@xylar Just a reminder to review when you have a chance |
Collaborator
|
Yes, it's on my list. Thanks for the reminder. |
Collaborator
|
I have tests in the Frontier queue. I'll report back as soon as they're done. The code changes look good to me! It makes sense to take advantage of the Omega time coordinate where we can. |
xylar
approved these changes
May 4, 2026
Collaborator
xylar
left a comment
There was a problem hiding this comment.
Looks great!
Polaris omega_pr suite
- Baseline workdir:
/lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-baseline - Baseline build:
/lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-baseline/build - PR build:
/lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-baseline/build - PR workdir:
/lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-xarray-time - Machine:
frontier - Partition:
batch - Compiler:
craygnu - Build type:
Release - Log:
/lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-xarray-time/polaris_omega_pr.o4527928 - Result: All tests passed
Collaborator
Author
|
@xylar Thanks for the review and testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most substantive change here is adding a new way to convert Omega's time variable to
daysSinceStartOfSimwhen xarray Datasets are loaded withdecode_times=True. The rest is a bit of clean-up and using this method in the seamount test case just to make sure that the clean-up didn't break MPAS-O xtime conversion.Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes