Skip to content

Take advantage of xarray's decode_times for Omega's time variable conversion#570

Merged
cbegeman merged 5 commits intoE3SM-Project:mainfrom
cbegeman:framework/augment-time-utils
May 4, 2026
Merged

Take advantage of xarray's decode_times for Omega's time variable conversion#570
cbegeman merged 5 commits intoE3SM-Project:mainfrom
cbegeman:framework/augment-time-utils

Conversation

@cbegeman
Copy link
Copy Markdown
Collaborator

@cbegeman cbegeman commented Apr 29, 2026

The most substantive change here is adding a new way to convert Omega's time variable to daysSinceStartOfSim when xarray Datasets are loaded with decode_times=True. The rest is a bit of clean-up and using this method in the seamount test case just to make sure that the clean-up didn't break MPAS-O xtime conversion.

Checklist

  • [N/A] User's Guide has been updated
  • [N/A] Developer's Guide has been updated
  • [N/A] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • [N/A] Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • [N/A] New tests have been added to a test suite

@cbegeman cbegeman force-pushed the framework/augment-time-utils branch from 5a009f2 to be04b9d Compare April 29, 2026 19:20
@cbegeman
Copy link
Copy Markdown
Collaborator Author

Testing

The full omega_pr test suite ran successfully. Some of the baseline comparisons failed because I used an older test instead of re-running with main.

### Polaris `omega_pr` suite
- Baseline workdir: `/pscratch/sd/c/cbegeman/polaris-scratch/ztilde-omega-develop-20260427`
- Baseline build: `/pscratch/sd/c/cbegeman/polaris-scratch/ztilde-omega-develop-20260427/build`
- PR build: `/pscratch/sd/c/cbegeman/polaris-scratch/ztilde-omega-develop-20260427/build`
- PR workdir: `/pscratch/sd/c/cbegeman/polaris-scratch/enhancetime-omega-develop-20260429`
- Machine: `pm-cpu`
- Compiler: `gnu`
- Build type: `Release`
- Log: not found
- Result:
  - Diffs (2 of 10):
    - `ocean/column/horiz_press_grad/salinity_gradient`
    - `ocean/planar/barotropic_gyre/munk/free-slip`

@cbegeman cbegeman marked this pull request as ready for review April 29, 2026 20:40
@cbegeman cbegeman self-assigned this Apr 30, 2026
@cbegeman cbegeman requested a review from xylar April 30, 2026 22:39
@cbegeman cbegeman added framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to the ocean component labels Apr 30, 2026
@cbegeman
Copy link
Copy Markdown
Collaborator Author

cbegeman commented May 4, 2026

@xylar Just a reminder to review when you have a chance

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented May 4, 2026

Yes, it's on my list. Thanks for the reminder.

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented May 4, 2026

I have tests in the Frontier queue. I'll report back as soon as they're done. The code changes look good to me! It makes sense to take advantage of the Omega time coordinate where we can.

Copy link
Copy Markdown
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Polaris omega_pr suite

  • Baseline workdir: /lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-baseline
  • Baseline build: /lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-baseline/build
  • PR build: /lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-baseline/build
  • PR workdir: /lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-xarray-time
  • Machine: frontier
  • Partition: batch
  • Compiler: craygnu
  • Build type: Release
  • Log: /lustre/orion/cli115/scratch/xylar/polaris_1.0/frontier/test_20260504/omega-pr-xarray-time/polaris_omega_pr.o4527928
  • Result: All tests passed

@cbegeman cbegeman merged commit 48d7544 into E3SM-Project:main May 4, 2026
5 checks passed
@cbegeman cbegeman deleted the framework/augment-time-utils branch May 4, 2026 19:48
@cbegeman
Copy link
Copy Markdown
Collaborator Author

cbegeman commented May 4, 2026

@xylar Thanks for the review and testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to the ocean component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants