Add a design documents for the unified base mesh#521
Add a design documents for the unified base mesh#521xylar wants to merge 22 commits intoE3SM-Project:mainfrom
Conversation
|
This is a draft, but feel free to comment and give feedback. |
|
I'm going to fold #522 into this branch. It is too much effort to keep the designs separate. |
b25da60 to
2a8cc8f
Compare
changliao1025
left a comment
There was a problem hiding this comment.
Since buffer zone will be introduced "land-ward" during the coastline preprocessing, we might need to record both the raw and buffered spacing rasters for coastline.
I don't quite follow what you mean. But we can easily recover a mask from the signed distance function that includes all cells that are a given distance or further from the coastline in either direction. For example, |
e12adeb to
0378e56
Compare
I assume you meant geodesic distance? |
It actually uses Cartesian distance but you have to be very far from the coastline for that to make a difference. |
ada159a to
e890d22
Compare
This mesh is intended to work for the E3SM land, river, ocean and sea-ice components
Also, clarify a bit what the scope of build_sizing_field actually is.
Here, we add more considerations about lat-lon resolution that is sufficient for defining a reasonable coastline. We also add a flood fill to make sure the ocean is contiguous. Finally, we add 3 different masks for the coastline in Antarctica: calving front, grounding line or zero bedrock elevation (for wetting-and-drying).
55c838d to
c2fc31e
Compare
This mesh is intended to work for the E3SM land, river, ocean and sea-ice components.
This PR also adds design docs for 4 shared steps related to the unified base mesh, tentatively named :
prepare_coastlineprepare_river_networkbuild_sizing_fieldcreate_base_meshChecklist