Skip to content

Enable thickness advection for Omega sphere transport tests#476

Merged
cbegeman merged 2 commits intoE3SM-Project:mainfrom
cbegeman:omega/fix-sphere-transport-tendencies
Mar 6, 2026
Merged

Enable thickness advection for Omega sphere transport tests#476
cbegeman merged 2 commits intoE3SM-Project:mainfrom
cbegeman:omega/fix-sphere-transport-tendencies

Conversation

@cbegeman
Copy link
Copy Markdown
Collaborator

@cbegeman cbegeman commented Mar 2, 2026

Fixes #463

@cbegeman cbegeman self-assigned this Mar 2, 2026
@cbegeman cbegeman marked this pull request as draft March 2, 2026 16:58
@cbegeman cbegeman added bug Something isn't working Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished labels Mar 2, 2026
@cbegeman
Copy link
Copy Markdown
Collaborator Author

cbegeman commented Mar 2, 2026

Testing

Results with Omega, icos rotation_2d on chrys, intel, openmpi:

This branch

  • Order of convergence for tracer1: 1.815
  • Order of convergence for tracer2: 1.662
  • Order of convergence for tracer3: 0.275

Baseline

  • Order of convergence for tracer1: 1.614
  • Order of convergence for tracer2: 1.662
  • Order of convergence for tracer3: 0.275

@cbegeman cbegeman requested a review from xylar March 5, 2026 17:15
@cbegeman cbegeman marked this pull request as ready for review March 5, 2026 17:16
@cbegeman cbegeman added the ocean Related to the ocean component label Mar 5, 2026
@cbegeman
Copy link
Copy Markdown
Collaborator Author

cbegeman commented Mar 6, 2026

@xylar This is a small fix. Do you mind approving? We just need it sometime before E3SM-Project/Omega#316 is merged.

Copy link
Copy Markdown
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good!

@cbegeman cbegeman merged commit 8b70d7e into E3SM-Project:main Mar 6, 2026
7 checks passed
@xylar xylar deleted the omega/fix-sphere-transport-tendencies branch March 10, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ocean Related to the ocean component Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sphere transport tests shouldn't disable thickness advection for Omega

2 participants