Fix mesh filename from init steps in convergence tasks#442
Merged
xylar merged 3 commits intoE3SM-Project:mainfrom Jan 5, 2026
Merged
Fix mesh filename from init steps in convergence tasks#442xylar merged 3 commits intoE3SM-Project:mainfrom
xylar merged 3 commits intoE3SM-Project:mainfrom
Conversation
Many convergence tasks have init steps with `culled_mesh.nc`, not `mesh.nc` as the final mesh file name. Here, we add a parameter to `ConvergenceForward` that specifies the mesh file name in the init step so this can be specified as appropriate.
These files were never cached (or perhaps need to be updated)
Collaborator
Author
TestingI ran the Before this fix, the
This may indicate that the geostrophic test is not configured correctly (e.g. the time step is too large) but it does not seem to be related to this PR and reported in #443 |
Collaborator
Author
|
@cbegeman, when you're back and have some time, please take a look. |
12 tasks
Collaborator
Author
|
Thank you for having a look, @cbegeman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many convergence tasks have init steps with
culled_mesh.nc, notmesh.ncas the final mesh file name. Here, we add a parameter toConvergenceForwardthat specifies the mesh file name in the init step so this can be specified as appropriate.The need for
mesh.ncwas introduced in #437 but it seems I rushed the review a little too much and didn't do enough testing to notice that the symlink was broken for many tasks.This PR also fixes two small issues discovered when running the
convergencesuite:/in the name of the merry-go-round task paths is dropped for consistency with other task pathsconvergencesuite is updated to not require cached files that were seemingly never created forexternal_gravity_waveChecklist
Testingcomment in the PR documents testing used to verify the changes