WIP: Add support for Omega's PseudoThickness variable#440
Draft
xylar wants to merge 12 commits intoE3SM-Project:mainfrom
Draft
WIP: Add support for Omega's PseudoThickness variable#440xylar wants to merge 12 commits intoE3SM-Project:mainfrom
PseudoThickness variable#440xylar wants to merge 12 commits intoE3SM-Project:mainfrom
Conversation
xylar
added
ocean
This was referenced Dec 19, 2025
4 tasks
Collaborator
Author
|
Much of this work is now included in #464 |
xylar
force-pushed
the
support-omega-pseudo-thickness
branch
from
b465575 to
8b0bc09
Compare
xylar
commented
Apr 27, 2026
Comment on lines
+131
to
+133
| 'ocean.QU.240km.omega_vars.251219.nc', | ||
| 'PlanarPeriodic48x48.omega_vars.251219.nc', | ||
| 'cosine_bell_icos480.omega_vars.250219.nc', |
Collaborator
Author
There was a problem hiding this comment.
Need to be updated again.
xylar
force-pushed
the
support-omega-pseudo-thickness
branch
2 times, most recently
from
d225583 to
7267693
Compare
This is needed so we can compute the reference pseudo-thickness for p* from `restingThickness`. This merge also adds support for multiple iterations when computing pseudo-thickness using TEOS-10.
Switch layerThickness --> GeometricLayerThickness Add a few vertical coordinate variables
The new meshes have as many variables as possible mapped to the new Omega names, and include PseudoThickness (if they previously had layerThickness) as well as GeometricLayerThickness. The PseudoThickness is computed using TEOS-10 for the specific volume.
We no longer assume that `LayerThickness` exists (and that it is pseudo-thickness). Instead, we explicitly compute only `PseudoThickness` and `SpecVol` when writing a model dataset and compute `GeomLayerThickness` if needed when reading it back.
This is in anticipation of other code besides just the vertical coordinate diagnostics needing this capability.
xylar
force-pushed
the
support-omega-pseudo-thickness
branch
3 times, most recently
from
8b2cadb to
8e99646
Compare
Following the renaming of fields, trying to leverage the same infrastructure is unnecessarily complicated and poteintially limiting.
xylar
force-pushed
the
support-omega-pseudo-thickness
branch
from
f4f15be to
782681e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes