Skip to content

Add an SSH check to VertCoordTest#411

Draft
cbegeman wants to merge 1 commit into
E3SM-Project:developfrom
cbegeman:omega/add-ssh-vert-coord-test
Draft

Add an SSH check to VertCoordTest#411
cbegeman wants to merge 1 commit into
E3SM-Project:developfrom
cbegeman:omega/add-ssh-vert-coord-test

Conversation

@cbegeman
Copy link
Copy Markdown

@cbegeman cbegeman commented May 18, 2026

Add an SSH check to VertCoordTest

Checklist

  • [N/A] Documentation:
  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • [N/A] The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • [N/A] Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
      • Document testing used to verify the changes including any tests that are added/modified/impacted.
      • [N/A] Performance related PRs: Please include a relevant PACE experiment link documenting performance before and after.
    • [N/A] New tests:
      • [N/A] CTest unit tests for new features have been added per the approved design.
      • [N/A] Polaris tests for new features have been added per the approved design (and included in a test suite)
  • [N/A] Stealth Features
    • [N/A] If any stealth features are included in the PR, please confirm that they have been documented.

@cbegeman
Copy link
Copy Markdown
Author

@brian-oneill Do you think this would be useful to add to the CTests? I had this idea too late for inclusion in #335

@brian-oneill
Copy link
Copy Markdown

Yeah, it's a good consistency check for the VertCoord. Even though SSH is just the the top-most value of ZInterface, wouldn't hurt to add this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants