Add OcnInit overload that uses coupler provided parameters#399
Closed
andrewdnolan wants to merge 3 commits intoE3SM-Project:developfrom
Closed
Add OcnInit overload that uses coupler provided parameters#399andrewdnolan wants to merge 3 commits intoE3SM-Project:developfrom
OcnInit overload that uses coupler provided parameters#399andrewdnolan wants to merge 3 commits intoE3SM-Project:developfrom
Conversation
f4b4a39 to
4e898c6
Compare
Author
|
Closed in favor of #400 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an overload of
OMEGA::OcnInitthat expects:as arguments, which will be provided by the coupled driver instead of being read from the config file. This will be used by the coupled driver, which is currently in progress.
This PR refactors the
TimeStepperclass, to enable theStopTimeto be optional. In coupled E3SM simulation the components are not told the stop time. Instead the coupled driver is responsible for finalizing everything, in our case by calling theocn_final_mctsubroutine fromocn_comp_mct.F90(which will be defined in a separate PR). The reordering of arguments to theTimeStepperconstructor was needed because the optional arguments must come last.Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build