Skip to content

Revert "Update scorpio"#360

Merged
xylar merged 1 commit intoE3SM-Project:developfrom
xylar:omega/revert-scorpio-update
Mar 18, 2026
Merged

Revert "Update scorpio"#360
xylar merged 1 commit intoE3SM-Project:developfrom
xylar:omega/revert-scorpio-update

Conversation

@xylar
Copy link
Copy Markdown

@xylar xylar commented Mar 13, 2026

This reverts commit dfcffe1.

We should not have updated an external submodule directly in Omega in #325 (my mistake!). Instead, we need to bring in changes like this scorpio update via merging E3SM/master into Omega/develop. I will follow up immediately with such a merge.

Checklist

  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
      • Document testing used to verify the changes including any tests that are added/modified/impacted.
      • Performance related PRs: Please include a relevant PACE experiment link documenting performance before and after.

This reverts commit dfcffe1.
@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 13, 2026

This is required before #361 to avoid conflicts and to keep things clear.

@xylar xylar mentioned this pull request Mar 13, 2026
6 tasks
@xylar
Copy link
Copy Markdown
Author

xylar commented Mar 13, 2026

Testing

Tested together with #361. See #361 (comment).

@xylar xylar requested review from sbrus89 March 13, 2026 16:52
@xylar xylar self-assigned this Mar 13, 2026
@xylar xylar merged commit d18f30d into E3SM-Project:develop Mar 18, 2026
@xylar xylar deleted the omega/revert-scorpio-update branch March 18, 2026 07:44
@sbrus89 sbrus89 mentioned this pull request Mar 26, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant