-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAMxx: simplify branch runs and adding new output streams #7063
base: master
Are you sure you want to change the base?
Conversation
Explicitly and automatically avoid the restart of any output stream
@@ -217,6 +217,7 @@ class AtmosphereDriver | |||
util::TimeStamp m_run_t0; | |||
util::TimeStamp m_case_t0; | |||
RunType m_run_type; | |||
bool m_branch_run = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about adding a new value to RunType, but it required a few more changes across the library. Maybe that's more appropriate though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone back and forth on this in my mind. I think this is probably okay as it is. I don't forsee a reason to use RunType=branch as an option outside of this application. Just to confirm, for the rest of the code RunType
will be Restart
for branch runs right?
|
Confirming this works. Cherry-picking these commits into a branch from December allowed a CIME style branch run to work without having to add "Perform Restart: false" to all the I/O yaml files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, otherwise looks good.
@@ -217,6 +217,7 @@ class AtmosphereDriver | |||
util::TimeStamp m_run_t0; | |||
util::TimeStamp m_case_t0; | |||
RunType m_run_type; | |||
bool m_branch_run = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone back and forth on this in my mind. I think this is probably okay as it is. I don't forsee a reason to use RunType=branch as an option outside of this application. Just to confirm, for the rest of the code RunType
will be Restart
for branch runs right?
Simplify workflow for branch runs, and, in general, runs where new output streams are added upon restart.
[BFB]
Right now, for branch runs, the user needs to add the entry
Perform Restart: false
entry in theRestart
sublist of their output yaml file. This allows EAMxx to skip the look for the rhist file. However, the user must later remove this entry, so that upon subsequent restarts the stream IS restarted. This is confusing, and may be overlooked.This PR automatically handles this kind of details. In particular:
Perform Restart: false
withskip_restart_if_rhist_not_found: true
. This makes it simpler, since this param does not need to be removed after the 1st "post-restart-run"