Migrate FATES parameter file switches to the namelist #6918
+256
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit facilitates moving this switch from the fates parameter file to the API. Note that the actual daylength factor value is always passed through the API. This just adds the switch to tell FATES to use it.
|
To do:
|
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
This commit facilitates moving this switch from the FATES parameter file to the namelist
glemieux
force-pushed
the
fates-parameter-namelist_switch-migration
branch
from
019da9d to
db8e2cb
Compare
glemieux
changed the title
Co-authored-by: Gregory Lemieux <[email protected]>
Co-authored-by: Gregory Lemieux <[email protected]>
Co-authored-by: Gregory Lemieux <[email protected]>
Co-authored-by: Gregory Lemieux <[email protected]>
Co-authored-by: Gregory Lemieux <[email protected]>
…witch-migration add electron transfer namelist switch
| @@ -428,7 +429,8 @@ subroutine ELMFatesGlobals2() | |||
| integer :: pass_regeneration_model | |||
| integer :: pass_hydro_solver | |||
| integer :: pass_radiation_model | |||
|
|
|||
| integer :: pass_electron_transfer_model | |||
There was a problem hiding this comment.
this should be pass_electron_transport_model (not transfer)
| @@ -359,6 +359,62 @@ Toggle to turn on FATES no competition mode (only relevant if FATES is being use | |||
| Toggle to turn on FATES satellite phenology mode (only relevant if FATES is being used). | |||
| </entry> | |||
|
|
|||
| <entry id="fates_radiation_model" type="char*256" category="physics" | |||
| group="elm_inparm" valid_values="norman, twostream" value="norman"> | |||
There was a problem hiding this comment.
There can't be any spaces between the valid values - e.g. this should be "norman,twostream"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves switch options located in the FATES parameter file into the ELM namelist.
Addresses NGEET/fates#1295.
To be coordinated with NGEET/fates#1300.
[non-BFB] for FATES tests only