DYN-8586: Update script to use boto3 #16008
Open
+17
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8586
zeusongit
commented
Mar 27, 2025
| s3.upload_file( | ||
| Filename=fn, | ||
| Bucket=bucket_name, | ||
| Key=os.path.basename(key), |
There was a problem hiding this comment.
Hey @QilongTang, I had a question here, a few lines above we are prefixing the file name with other things, but here we are passing just the file name. Should we remove the line above?
There was a problem hiding this comment.
The key seems to be the date string 20250327T0518 from e.g. DynamoCoreRuntime_3.5.0.8161_20250327T0518.zip. Maybe not change this for now
There was a problem hiding this comment.
Per our conversation at standup, feel free to make the change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Python version (3.8) that we are using in build machine has officially EOL, in order to update the build machine to latest version of python the PR updates the script to use
boto3python library, that supports latest(3.13) version of python.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/eidos