[DYN-8392] Python dependencies in workspace references. #15948
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8392
| @@ -804,6 +805,18 @@ private List<INodeLibraryDependencyInfo> ComputeNodeLibraryDependencies() | |||
| { | |||
| var collected = GetNodePackage(node); | |||
|
|
|||
| // Handle python nodes explicitly and use the collected node package for those node type. | |||
| if (node.ToString().Equals(pythonNodeNamespace) && collected != null) | |||
There was a problem hiding this comment.
Checking this instead of the node type because the core cannot have dependency reference with PythonNodeModels project.
| @@ -187,10 +187,6 @@ internal void DependencyRegen(WorkspaceModel ws, bool forceCompute = false) | |||
| HasDependencyIssue = string.IsNullOrEmpty(info.Path); | |||
| } | |||
|
|
|||
| var pythonPackageDependencies = ws.OnRequestPackageDependencies(); | |||
There was a problem hiding this comment.
Removed this as the OnRequestPackageDependencies was just setting the ironpython package details with a fixed version if the workspace has a ironpython2 node. Now, we will compute the dependency package directly when the engine is changed and the script is saved. Should handle Cpython and pythonnet3 cases as well.
|
Worth adding a test? |
|
@zeusongit There is a already a similar test and I modified that to verify the dependency change when the python engine is modified. |
|
There are some test failures, let's retry merging master into your branch |
|
@reddyashish Can you take a look at the failing smoke test. |
|
This is ready to review. Fixed all the edge cases and now it dynamically computes the python package dependency based on the python node engine. |
|
Who is @DreadPirateRoberts90 ? |
|
Haha, that was my different account which i did not notice on my windows instance. |
Co-authored-by: Ashish <[email protected]> (cherry picked from commit 2f57b87)
|
Successfully created backport PR for |
Purpose
https://jira.autodesk.com/browse/DYN-8392
Python engine dependency in workspace references should update when the user changes the python engine and saves it.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
@zeusongit @aparajit-pratap