Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Revert to default logging #336

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Mar 14, 2024

With this PR, our central logging config is rolled back. We as lib should never overwrite the root logger of the application that uses us.
This can cause problems, as all logs of the main application will be intercepted by our logger. This should fix this behaviour: DurgNomis-drol/ha_toyota#242

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.73%. Comparing base (97c6f36) to head (58c7e63).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   82.66%   82.73%   +0.06%     
==========================================
  Files          31       29       -2     
  Lines        1442     1413      -29     
==========================================
- Hits         1192     1169      -23     
+ Misses        250      244       -6     
Flag Coverage Δ
unittests 82.73% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@moonter45 moonter45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working well :)

@fenty17
Copy link

fenty17 commented Mar 21, 2024

Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way.

@desosav
Copy link

desosav commented Mar 25, 2024

Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way.

You can select the specific branch until it is merged by updating the custom_components/toyota/manifest.json file in homeassistant.
Replace requirements with the following and restart

"requirements": [ "mytoyota @ git+https://github.com/DurgNomis-drol/mytoyota/tree/enhancement/revert_to_default_logging", "arrow" ],

I am so glad my error messages are back :)

@CM000n
Copy link
Collaborator Author

CM000n commented Mar 26, 2024

Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way.

Still waiting for approval 😞

@CM000n CM000n merged commit 709a8b7 into master Mar 26, 2024
21 checks passed
@CM000n CM000n deleted the enhancement/revert_to_default_logging branch March 26, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants