-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Revert to default logging #336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 82.66% 82.73% +0.06%
==========================================
Files 31 29 -2
Lines 1442 1413 -29
==========================================
- Hits 1192 1169 -23
+ Misses 250 244 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and working well :)
Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way. |
You can select the specific branch until it is merged by updating the custom_components/toyota/manifest.json file in homeassistant.
I am so glad my error messages are back :) |
Still waiting for approval 😞 |
With this PR, our central logging config is rolled back. We as lib should never overwrite the root logger of the application that uses us.
This can cause problems, as all logs of the main application will be intercepted by our logger. This should fix this behaviour: DurgNomis-drol/ha_toyota#242