Enhancement: use importlib_metadata as a dependency across all Python versions
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 75.23% 75.33% +0.09%
==========================================
Files 27 27
Lines 1280 1277 -3
==========================================
- Hits 963 962 -1
+ Misses 317 315 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CM000n
changed the title
importlib-metadata dependency
CM000n
changed the title
importlib-metadata dependencyimportlib_metadata as a dependency across all Python versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer support Python < 3.8 ourselves, but
importlib.metadataitself is removed from the Pythonstdlibwith Python >= 3.10, a consistent suggestion here would be to useimportlib_metadataas a dependency across all Python versions.