Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumes "auto" as source language if only one lang is passed #11

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fabchelly
Copy link

Allows to specify the destination language to search faster

fchelly and others added 2 commits April 7, 2022 17:49
…ided.

Using google table of languages to check if parameter is a valid language.

Detecting language before translation to be able to display the right language if "auto" has been used.
@fabchelly
Copy link
Author

Allows to translate with no lang param is provided

@deefrawley
Copy link

Hi @fabchelly - we have forked this repo as the active version of the plugin until Drmix20 can work on this one again. Could you add this PR to https://github.com/deefrawley/Flow.Launcher.Plugin.DirectTranslate ? Thanks

@fabchelly
Copy link
Author

Those modifications allow me to translate far more faster

@deefrawley
Copy link

Yep it's a good PR and something other people are after. Can you please make the PR to my fork and I will approve it and it will trigger a new plugin release.

@fabchelly
Copy link
Author

It is done.
I made the PR. Since the first PR, I have added the ability to provide no lang code at all. It allows to translate from auto to the default system language. Its is very useful to translate any foreign sentence into our own language easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants