Skip to content

Adding gpgid field #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adding gpgid field #4

wants to merge 2 commits into from

Conversation

HugoJH
Copy link

@HugoJH HugoJH commented Jan 27, 2022

Added gpgid field so GPG keys can be configured to be used on that repo.

@DrVanScott
Copy link
Owner

DrVanScott commented Feb 4, 2022

Hi, i like the idea of adding the optional possibility for a gpgid. But I don't agree with the default commit.gpgsign=true.

Linus Torvalds about this topic:

Signing each commit is totally stupid. It just means that you automate it, and you make the signature worth less. It also doesn't add any real value, since the way the git DAG-chain of SHA1's work, you only ever need one signature to make all the commits reachable from that one be effectively covered by that one. So signing each commit is simply missing the point.

So, i would prefer either not setting commit.gpgsign or also make this one configurable (with by default not to change this setting). What do you think?

@DrVanScott
Copy link
Owner

I will close this PR but open another one based on your changes: #9

@DrVanScott DrVanScott closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants