Feat: support grouped Options in Virtualized Select #2643 #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 453ee0b:
|
|
@YyumeiZhang 您好，可以麻烦看看这个pr嘛，如果有需要改进的地方可以指点下嘛 |
YyumeiZhang
reviewed
Jan 20, 2025
packages/semi-ui/select/index.tsx
Outdated
|
|
||
| content.push(option); | ||
| }); | ||
|
|
||
| return ( | ||
| <List | ||
| ref={this.virtualizeListRef} | ||
| height={height || numbers.LIST_HEIGHT} | ||
| itemCount={visibleOptions.length} |
There was a problem hiding this comment.
itemCount={visibleOptions.length} 应该修改为content 的 size ？
There was a problem hiding this comment.
itemCount={visibleOptions.length} 应该修改为content 的 size ？
感谢回复，在有分组标题头的情况下这两者确实有差别，渲染的高度有差异，用content.length会更准确一些，已更改
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
阅读了相关源码我认为问题本质是虚拟滚动和分组渲染的实现方式不兼容，我尝试修改了虚拟列表渲染的逻辑，增加了对于分组情况的支持。
Checklist
Other
Additional information