Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Collapsible] remove useless isEqual compare in componentDidUpdate #2631

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 去除 Collapsible 组件更新时多余的属性前后是否变化对比

🇺🇸 English

  • Fix: Remove redundant calculations to determine whether the properties have changed when the Collapsible component is updated.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d71a328:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Dec 13, 2024

semi-design    Run #3018

Run Properties:  status check passed Passed #3018  •  git commit 615b95ae6f ℹ️: Merge d71a32889ae5cfe9a219e00f6de45bdcd025384d into f41c4939fb79091c905bb512991b...
Project semi-design
Branch Review fix/collapsible-compare
Run status status check passed Passed #3018
Run duration 07m 50s
Commit git commit 615b95ae6f ℹ️: Merge d71a32889ae5cfe9a219e00f6de45bdcd025384d into f41c4939fb79091c905bb512991b...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 277
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@DaiQiangReal DaiQiangReal merged commit 3579733 into main Dec 13, 2024
10 checks passed
@DaiQiangReal DaiQiangReal deleted the fix/collapsible-compare branch December 13, 2024 03:42
Copy link

cypress bot commented Dec 13, 2024

semi-design    Run #3019

Run Properties:  status check passed Passed #3019  •  git commit 3579733a4c: Merge pull request #2631 from DouyinFE/fix/collapsible-compare
Project semi-design
Branch Review main
Run status status check passed Passed #3019
Run duration 07m 43s
Commit git commit 3579733a4c: Merge pull request #2631 from DouyinFE/fix/collapsible-compare
Committer 代强
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 277
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants