Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cascader repos Popover when search input change & item remove by… #2417

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

… click close icon

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #
内部用户反馈,Cascader 位置在屏幕靠近右侧,搜素时候,popover 的位置没有根据内容重新计算,导致搜索后的选项面板被遮挡。
重新计算弹出层位置只能解决部分问题,如果内容实在太长,需考虑 filterRender 自定义渲染,控制弹出层的长度。

本PR 中修改处理包括两点

  1. 在搜索值变化后,触发位置重新计算,解决搜索时候的位置计算问题
  2. 多选状态下,通过点击 trigger 中已选项的关闭 icon 取消选中,弹出层位置未重新计算问题。

Changelog

🇨🇳 Chinese

  • Fix: 修复 Cascader 搜索后以及多选,弹出层的位置未重新计算,导致内容较长的面板被遮挡问题。
  • Fix: 修复多选的 Cascader 中,通过点击 trigger 中已选项的关闭 icon 取消选中,弹出层位置未重新计算问题。

🇺🇸 English

  • Fix: Fixed the problem that after Cascader search, the position of the pop-up layer was not recalculated, causing panels with long content to be blocked.
  • Fix: Fixed the problem that in multi-selected Cascader, the pop-up layer position is not recalculated by clicking the selected close icon in the trigger to uncheck it.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YyumeiZhang YyumeiZhang requested a review from pointhalo August 16, 2024 09:50
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eef1d97:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Aug 16, 2024



Test summary

267 0 11 0


Run details

Project semi-design
Status Passed
Commit c613b34 ℹ️
Started Aug 16, 2024 10:02 AM
Ended Aug 16, 2024 10:12 AM
Duration 10:10 💡
OS Linux Debian -
Browser Chrome 103

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@pointhalo pointhalo merged commit 4de0ba7 into main Aug 19, 2024
10 checks passed
@pointhalo pointhalo deleted the fix/cascader-reposWhenSearch branch August 19, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants