Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avatar size support raw value #2290

Merged
merged 4 commits into from
Jun 11, 2024
Merged

feat: avatar size support raw value #2290

merged 4 commits into from
Jun 11, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

@DaiQiangReal DaiQiangReal commented Jun 11, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Feat: Avatar size 支持传入合法的 width 属性值例如 "10px"

🇺🇸 English

  • Feat: Avatar size support valid value like "10px"

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Jun 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26d717a:

Sandbox Source
pr-story Configuration

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.20%. Comparing base (8591552) to head (0a6b889).

Current head 0a6b889 differs from pull request most recent head 7134eb3

Please upload reports for the commit 7134eb3 to get more accurate results.

Files Patch % Lines
packages/semi-ui/avatar/index.tsx 58.33% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   88.26%   88.20%   -0.06%     
==========================================
  Files         441      441              
  Lines       26072    26077       +5     
  Branches     6659     6661       +2     
==========================================
- Hits        23012    23001      -11     
- Misses       3060     3076      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jun 11, 2024

Passing run #2552 ↗︎

0 260 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7134eb3 into 8591552...
Project: semi-design Commit: 0a6b889baa ℹ️
Status: Passed Duration: 10:46 💡
Started: Jun 11, 2024 7:46 AM Ended: Jun 11, 2024 7:57 AM

Review all test suite changes for PR #2290 ↗︎

@@ -437,7 +437,7 @@ import { Avatar, AvatarGroup } from '@douyinfe/semi-ui';
| hoverMask | Avatar content overlay when hover | ReactNode | - |
| imgAttr | Native html img attributes **>=1.5.0** | React.ImgHTMLAttributes<HTMLImageElement\> | - |
| shape | Shape of the avatar, one of `circle`, `square` | string | `circle` |
| size | Size of the avatar, one of `extra-extra-small`,`extra-small`, `small`, `default`, `medium`, `large`, `extra-large` | string | `medium` |
| size | Size of the avatar, one of `extra-extra-small`,`extra-small`, `small`, `default`, `medium`, `large`, `extra-large` and raw value | string | `medium` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉 raw value 以及 字面量的理解门槛都有点高。尤其是 raw value。

@DaiQiangReal DaiQiangReal merged commit c7805a3 into main Jun 11, 2024
4 of 5 checks passed
@DaiQiangReal DaiQiangReal deleted the feat_avatar_size_raw branch June 11, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants