Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix recur fieldPath type error when not passing generics type #2259

Merged
merged 5 commits into from
May 29, 2024

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented May 29, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

解决 PR #2245 带来的问题
变更历史详情查阅飞书文档:https://bytedance.larkoffice.com/docx/BuxWddiCoo4KYZxFL7xcu1Xmn0f

Changelog

🇨🇳 Chinese

  • Fix: 修复 FormApi 在未传入泛型时,调用 setValue时会有 string类型不能赋值给 never 的类型报错问题(影响范围,v2.59.0 )
  • Chore: 优化 FormApi getValue 对于嵌套路径的类型提示,对齐 setValue 行为

🇺🇸 English

  • Fix: Fixed the problem that when FormApi does not pass in generics, there will be a type error that string type cannot be assigned to never when calling setValue (affected scope, v2.59.0)
  • Chore: Optimize ·FormApi getValue type hints for nested paths and align setValue behavior

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@pointhalo pointhalo changed the title Fix form api type chore: fix recur fieldaPath type error when not passing generics type May 29, 2024
@pointhalo pointhalo changed the title chore: fix recur fieldaPath type error when not passing generics type chore: fix recur fieldPath type error when not passing generics type May 29, 2024
Copy link

codesandbox-ci bot commented May 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

cypress bot commented May 29, 2024

Passing run #2524 ↗︎

0 247 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge eeb24b1 into 1bab832...
Project: semi-design Commit: 4f19058d29 ℹ️
Status: Passed Duration: 10:21 💡
Started: May 29, 2024 7:17 AM Ended: May 29, 2024 7:27 AM

Review all test suite changes for PR #2259 ↗︎

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (c8e6d8d) to head (4f19058).
Report is 8 commits behind head on main.

Current head 4f19058 differs from pull request most recent head eeb24b1

Please upload reports for the commit eeb24b1 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
- Coverage   88.16%   87.69%   -0.47%     
==========================================
  Files         441      441              
  Lines       26060    26071      +11     
  Branches     6654     6658       +4     
==========================================
- Hits        22975    22864     -111     
- Misses       3085     3207     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit db63f22 into main May 29, 2024
5 of 6 checks passed
@pointhalo pointhalo deleted the fix-formApiType branch May 29, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants