Update SA1316 to not trigger in tuple types which are part of a member's signature, if that member is an override #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3782 +/- ##
==========================================
+ Coverage 94.37% 97.45% +3.08%
==========================================
Files 924 924
Lines 109815 110198 +383
Branches 3302 3310 +8
==========================================
+ Hits 103635 107394 +3759
+ Misses 5170 1839 -3331
+ Partials 1010 965 -45 |
|
Any comments on this, @sharwell? |
…CorrectCasing unless a diagnostic will be issued
bjornhellander
force-pushed
the
sa1316-member-override
branch
from
6f94c20
to
7ea2d3f
Compare
…r's signature, if that member is an override or implements an interface DotNetAnalyzers#3781
bjornhellander
force-pushed
the
sa1316-member-override
branch
from
7ea2d3f
to
d1b6183
Compare
|
Rebased and updated to also handle members implemented from an interface, making it a complete fix for the linked issue. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #3781.Handles originally reported case (overrides), but not the case of implementing an interface.
Updated to fix the issue completely.