Add initial code and tests for the SA1414 Analyzer for converting fie… #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds that are marked internal as internal auto properties.
|
@sharwell uh I think I need help with figuring out the failed tests. I would debug them but I still cannot build due to the same issue I have from the other pull request. |
allves90
previously approved these changes
Sep 10, 2018
|
going to debug the if now and find out why the 1 test fails. |
|
@AraHaan Did you update the permissions as described in the issue I linked to? |
|
yes, I did. |
|
LOL seems like a GitHub bug now... Why is it always me that finds the bugs. 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
==========================================
- Coverage 97.37% 97.37% -0.01%
==========================================
Files 751 753 +2
Lines 99421 99492 +71
Branches 3263 3270 +7
==========================================
+ Hits 96816 96883 +67
- Misses 1736 1738 +2
- Partials 869 871 +2 |
|
@sharwell I think the build bugged out on the powershell script. It works properly locally though. |
sharwell
reviewed
Sep 10, 2018
...p.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1414InternalFieldMustBeAutoProperty.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lds that are marked internal as internal auto properties.
See #2780. I closed the other pull request for this as I think this would be a great thing to add to help people with fields they mark internal. However this excludes
static, andconstones for now as I am not sure if I can actually suggest making those auto properties.