Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created Migrate.md #1550

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

journeyman
Copy link

addresses requests from: #1099 and #1144

@codecov-io
Copy link

Current coverage is 77.28%

Merging #1550 into master will not affect coverage as of 08f001a

@@            master   #1550   diff @@
======================================
  Files          530     530       
  Stmts        32154   32154       
  Branches      8796    8796       
  Methods          0       0       
======================================
  Hit          24851   24851       
  Partial       5136    5136       
  Missed        2167    2167       

Review entire Coverage Diff as of 08f001a

Powered by Codecov. Updated on successful CI builds.

@@ -0,0 +1,16 @@
## Migration from Settings.StyleCop to FxCop.ruleset (using F#)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I'm a bit torn on this. It looks like a lot of work for relatively little gain. It's quite easy in my experience to use the rule set editor to configure the severity of rules. I have the following additional specific concerns:

  1. This only covers the severity of rules. Users will still have to configure stylecop.json separately and/or reconsider the severity of rules in cases where the behavior of this project does not precisely match StyleCop "classic".
  2. This script could enable rules which are currently disabled because they are either not implemented or are completely untested. It seems like it could manually configure the severity of rules which are permanently disabled, such as SA1603 (DocumentationMustContainValidXml) (see Permanently disable SA1603 (DocumentationMustContainValidXml) #1324). When rules are permanently disabled, a diagnostic descriptor for them is retained in order for the status site to extract information from them (it doesn't use it currently), but the diagnostic is hidden from the rule set editor interface.

@pdelvo
Copy link
Member

pdelvo commented May 17, 2016

Do we want to move this PR forward?

Copy link

@dmitryvhf dmitryvhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script checked. Easy in using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants