-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created Migrate.md #1550
base: master
Are you sure you want to change the base?
created Migrate.md #1550
Conversation
Current coverage is
|
@@ -0,0 +1,16 @@ | |||
## Migration from Settings.StyleCop to FxCop.ruleset (using F#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 I'm a bit torn on this. It looks like a lot of work for relatively little gain. It's quite easy in my experience to use the rule set editor to configure the severity of rules. I have the following additional specific concerns:
- This only covers the severity of rules. Users will still have to configure stylecop.json separately and/or reconsider the severity of rules in cases where the behavior of this project does not precisely match StyleCop "classic".
- This script could enable rules which are currently disabled because they are either not implemented or are completely untested. It seems like it could manually configure the severity of rules which are permanently disabled, such as SA1603 (DocumentationMustContainValidXml) (see Permanently disable SA1603 (DocumentationMustContainValidXml) #1324). When rules are permanently disabled, a diagnostic descriptor for them is retained in order for the status site to extract information from them (it doesn't use it currently), but the diagnostic is hidden from the rule set editor interface.
Do we want to move this PR forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script checked. Easy in using.
addresses requests from: #1099 and #1144