fix: buffer complete secret watch events - #562
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #536.
The watch reader currently passes each network read directly to the event parser. A read can contain part of an event or several events, so valid server responses can produce parse errors and missed updates.
Buffer lines until the blank line ending each SSE frame, normalize CRLF to LF for the existing parser, and dispatch each complete frame separately. An incomplete final frame is discarded; the connection error still propagates to the existing reconnect logic. Callback dispatch remains asynchronous.
Validation: all package tests pass (
go test ./pkg/...), and the HTTP package passes with the race detector. Four local HTTP regressions fail before this change and pass afterward: combined events, an event larger than the old 1024-byte buffer, CRLF frames, and a truncated final event. Formatting andgit diff --checkpass. The authenticated end-to-end suite was not run.