fix: make volume indicator text readable on dark background#1045
Open
aviadlevy wants to merge 1 commit into
Open
fix: make volume indicator text readable on dark background#1045aviadlevy wants to merge 1 commit into
aviadlevy wants to merge 1 commit into
Conversation
The volume indicator's Text had no explicit style, so it inherited the default theme text color (dark), which was unreadable against the 0.85-alpha black background. Match the brightness indicator by setting the text color to white. The icon already rendered correctly and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Sets an explicit white text color on the volume indicator overlay so its label is readable against the dark background.
The volume indicator's
Texthad no explicit style, so it inherited the default theme text color (dark), which was unreadable on the0.85-alpha black background. This matches the brightness indicator, which already sets the text color to white. The icon already rendered correctly and is unchanged.Issue Being Fixed
On Android, when increasing/decreasing the volume during video playback, the volume overlay's percentage text rendered dark-gray on black and was effectively unreadable. The volume icon was fine, and the brightness overlay (both icon and text) was already correct.
Screenshots / Recordings
Tested On
Checklist