Handle only bg or fg set when resolving cursor hl #85
Conversation
|
@casr Could you test these changes when you get a chance? I think/hope they fix the issue. |
|
Thank you! I'll have a play. On first glance it seems more complex than I thought it would turn out but I might need to catch up to where your thinking is at! I'll try and set up some tests across term, cterm, gui and termguicolors with different combinations of fg/bg. Hopefully that'll be useful to test against. It might take me a couple of days to get to the time together though if you don't mind a short wait. |
|
The complexity seems to be unavoidable as fg/gb/foreground/background are not valid values for |
|
The simplest option here would be just to always use the fallback (term=reverse cterm=reverse) in non-gui vim, which doesn't seem at all that unreasonable, but is a change to the existing behaviour. |
The previous code to resolve the cursor highlight didn't allow for only the background or foreground to be set, i.e. only one of guifg & guibg. This was done intentionally to keep the code simple, on the assumption that only setting either background or foreground was so rare that it didn't warrant the additional complexity, but it seems that assumption was misguided, while it is unusual, it's not rare enough to ignore. See #84 for background Thanks @casr for reporting this and researching in some detail :-)
mmrwoods
force-pushed
the
improve-resolve-cursor
branch
from
4c904fa to
d0c6385
Compare
|
btw, re fg/bg/foregound/background not being valid Having said that, this can be identified by checking for specific error numbers (see |
Slightly modified solution that allows bg, fg, background, foreground to
be used as ctermfg and ctermbg colors, but also handles specific errors
if these are used when the foreground or background colors are unknown.
Note: has('gui') is still necessary as the terminal foreground and
background will never be known while the gui is running.
Specify very magic, and make pattern a little stricter
The previous code to resolve the cursor highlight didn't allow for only
the background or foreground to be set, e.g. only one of guifg & guibg.
This was done intentionally to keep the code simple, on the assumption
that only setting either background or foreground was so rare that it
didn't warrant the additional complexity, but it seems that assumption
was misguided, while it is unusual, it's not rare enough to ignore.
See #84 for background
Thanks @casr for reporting this and researching in some detail :-)