Update syncPubKeyDomain to achene.app#1124
Merged
Merged
Conversation
The syncPubKeyDomain contained the key
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
PR Description Check PassedAll required sections are filled in correctly. Details |
pawel-kow
approved these changes
May 21, 2026
Merged
via the queue into
Domain-Connect:master
with commit May 21, 2026
53c0c04
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects
syncPubKeyDomainfromdomainconnect.achene.apptoachene.app.Update logo URL.
Background: Cloudflare builds the public-key TXT lookup as
{key}.{syncPubKeyDomain}. ThekeyURL parameter carries the sub-label prefix (domainconnect), so the full lookup domain must bedomainconnect.achene.app. The previous value (domainconnect.achene.app) caused Cloudflare to querydomainconnect.achene.app.domainconnect.achene.app, which does not exist. The JWT returned hadperms: []and the flow failed silently.No DNS records were changed — only the
syncPubKeyDomainmetadata field and the logo URL.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.json—achene.app.customdomain.jsonlogoUrlis actually served by a webserver —https://achene.app/favicon-light.svgChecklist of common problems
syncPubKeyDomainis set —achene.appwarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainis set —achene.app(used in the synchronous redirect flow)txtConflictMatchingMode— not applicable, no TXT recordshostlabel — no variables usedhostfield to create a subdomain —hostparameter is used viahostRequired: true%host%does not appear explicitly in anyhostattribute —hostis"@"(expands to the provided host parameter)essential— not applicable, no records the end user would need to modify independentlyOnline Editor test results
Editor test link(s):
Test achene.app/customdomain tinkr.co.uk/learn