Skip to content

added DNS template#1114

Closed
newtondev3 wants to merge 1 commit into
Domain-Connect:masterfrom
newtondev3:master
Closed

added DNS template#1114
newtondev3 wants to merge 1 commit into
Domain-Connect:masterfrom
newtondev3:master

Conversation

@newtondev3
Copy link
Copy Markdown
Contributor

@newtondev3 newtondev3 commented May 19, 2026

Description

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • [ x] Template functionality checked using Online Editor
  • [ x] Template file name follows the pattern <providerId>.<serviceId>.json
  • [x ] resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • [ x] syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • [ x] warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • [x ] syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • [ x] no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • [x ] txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • [ x] no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • [ x] no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • [x ] no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • [ x] %host% does not appear explicitly in any host attribute
  • [x ] essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):

Test newtoncelestial.com/website-creation-test example.com/@

@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels May 19, 2026
@github-actions
Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions
Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions
Copy link
Copy Markdown

Linter OK

newtoncelestial.com.website-creation-test.json

Level Code Note

@github-actions
Copy link
Copy Markdown

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found

Labels to add: Checklist of common problems not complete, PR description incomplete, Test links missing
Labels to remove: Forged editor links

PR description check FAILED:
  FAIL  'How Has This Been Tested?': no checkboxes found
  FAIL  'Checklist of common problems': no checkboxes found
  FAIL  Template coverage: newtoncelestial.com.website-creation-test.json: missing a test WITH host

@github-actions
Copy link
Copy Markdown

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 2/4 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found

Labels to add: Checklist of common problems not complete, PR description incomplete, Test links missing
Labels to remove: Forged editor links

PR description check FAILED:
  FAIL  'How Has This Been Tested?': no checkboxes found
  FAIL  'Checklist of common problems': no checkboxes found
  FAIL  Template coverage: newtoncelestial.com.website-creation-test.json: missing a test WITH host

@newtondev3 newtondev3 closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants