Fix discoverworthy.com.managed-hosting: APEXCNAME -> CNAME (hostRequired) for Cloudflare#1112
Merged
pawel-kow merged 1 commit intoMay 19, 2026
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
…ired CNAME Cloudflare rejects APEXCNAME; use a standard CNAME (CF flattens at apex). The Domain Connect schema requires hostRequired:true for a CNAME at host @; with hostRequired the apply is host-scoped (subdomain/www one-click) and bare apex uses a manual single CNAME. Single-record shape mirrors the merged magicpages.co.website-cname.json. variableDescription removed (optional; avoids editor textarea wrap mismatching the committed file). version 1 -> 2.
cf8e7c3 to
6be8d9e
Compare
PR Description Check PassedAll required sections are filled in correctly. Details |
pawel-kow
approved these changes
May 19, 2026
Merged
via the queue into
Domain-Connect:master
with commit May 19, 2026
a63e019
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix to the existing
discoverworthy.com.managed-hostingtemplate (added in #1110).The apex record was
APEXCNAME. Cloudflare does not support theAPEXCNAMEcustom record type and rejects it during Domain Connect onboarding (confirmed
by the Cloudflare Domain Connect maintainer). Cloudflare auto-applies CNAME
flattening at the zone apex, so the correct primitive is a standard
CNAME.Per the Domain Connect schema, a
CNAMEathost: "@"requires the templateto also set
"hostRequired": true. This PR therefore:APEXCNAMEwith a singleCNAMEathost: "@","hostRequired": true,wwwCNAME(underhostRequiredthe request host isthe subdomain, so a hardcoded
wwwrecord would mis-apply aswww.<host>.<domain>),variableDescription(not required; its only purposewas describing
%target%, whichdescriptionalready conveys),version1 → 2 (template modified after being merged).The resulting shape is identical to the already-merged
magicpages.co.website-cname.json. The record resolves to the customer'shosting target supplied via the signed
%target%variable.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserver (N/A — template sets nologoUrl)Checklist of common problems
syncPubKeyDomainis set (discoverworthy.app) — mandatory, presentwarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomain— N/A, synchronous flow uses noredirect_uritxtConflictMatchingMode— N/A, no TXT recordshostRequired: trueis set (required by the schema for aCNAMEat host@)%target%is thepointsToof a type-constrainedCNAMErecordhostlabel — host is fixed (@)hostfield to create a subdomain;%host%does not appear in anyhostattributeessential/OnApply— N/A, the single record is required for the service to functionOnline Editor test results
Editor test link:
Host set (subdomain — the only applicable case for a
hostRequiredtemplate):Test discoverworthy.com/managed-hosting example.com/test