Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure response content is preserved in HTTPError #180

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Ensure response content is preserved in HTTPError #180

merged 1 commit into from
Mar 31, 2025

Conversation

goncalossilva
Copy link
Member

Closes #89

@goncalossilva goncalossilva requested a review from a team as a code owner March 31, 2025 17:07
@goncalossilva goncalossilva requested review from proxi, lefcha and Copilot and removed request for a team and proxi March 31, 2025 17:07
Copilot
Copilot AI reviewed Mar 31, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the response content from an HTTPError is preserved for better error handling and debugging.

  • Changed the import path for DEFAULT_TOKEN
  • Modified the test to capture and assert the HTTPError response content

@goncalossilva goncalossilva mentioned this pull request Mar 31, 2025
Closed
@goncalossilva goncalossilva force-pushed the goncalossilva/preserve-response-content branch from 9cc31c7 to ed9fbda Compare March 31, 2025 17:27
@goncalossilva goncalossilva merged commit 55917bd into main Mar 31, 2025
1 check passed
@goncalossilva goncalossilva deleted the goncalossilva/preserve-response-content branch March 31, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lefcha lefcha Awaiting requested review from lefcha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve handling of API response with error message
1 participant
@goncalossilva