Add v1.1 feature for favourites entry point #517
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I haven't had a chance to have a full look through this yet, but one thing I was thinking of was maybe renaming this to "favourites" to stay aligned with the API naming. I'm aware Twitter renamed favourites to likes ages ago, but for twarc, for v1.1 I think it makes more sense to call them "favourites" but in v2, "likes" |
| self, user_id=None, screen_name=None, max_id=None, since_id=None, max_pages=None | ||
| ): | ||
| """ | ||
| Returns a collection of the most recent tweets posted |
There was a problem hiding this comment.
This description should be for favourites, not tweets posted
| id_type = "screen_name" if screen_name else "user_id" | ||
| log.info("starting user timeline for user %s", id) | ||
|
|
||
| if screen_name or user_id: |
There was a problem hiding this comment.
I'm confused about the logic here - I'm not sure what this if statement is for
igorbrigadir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.