-
Notifications
You must be signed in to change notification settings - Fork 1
[REFACTOR] 강사 새 외주 작성 수정사항 반영 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
016c95b
#40 [REFACTOR] 카테고리 섹션 UI 수정사항 반영
waldls a4ec7e4
#40 [MOD] 섹션 포커스 보더 색상 통일 및 사이즈 선택 UI 개선
waldls d2ab189
#40 [REFACTOR] 디자인 컨셉 키워드 카테고리 개편 및 Chip long 배리언트 추가
waldls 23cd072
#40 [FEAT] 디자인 컨셉 추가 입력창 및 선택 개수 제한 토스트 추가
waldls 1b1cac2
#40 [MOD] 토글 컴포넌트 및 색상 선택 섹션 수정사항 반영
waldls 68193e5
#40 [MOD] 자료 첨부 시 설명 필수 표시 및 필수 페이지 선택 섹션 텍스트 변경
waldls 039c94a
#40 [FEAT] 파일 업로드 에러처리 모달 추가
waldls 29bad61
#40 [FEAT] 날짜 드롭다운 항목 클릭 시 선택하기 없이 바로 날짜 확정되도록 인터랙션 추가
waldls 74e762a
#40 [CHORE] 텍스트 띄어쓰기 수정
waldls cedfb38
#40 [FEAT] 결제하기 버튼 위 에러 토스트 추가
waldls bbcdfe4
#40 [CHORE] FAQ 외부 링크 수정
waldls d15fa89
#40 [CHORE] disabled 상태 커서 default로 변경
waldls b47b140
#40 [FIX] 에러 토스트 사라지면 결제하기 버튼 재활성화되도록 수정
waldls 81dfd9b
Merge branch 'main' of https://github.com/Ditda-Official/Ditda-Fronte…
waldls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import Chip from "@/shared/ui/Chip"; | ||
|
|
||
| interface ConceptResultProps { | ||
| selectedKeywords: string[]; | ||
| onRemove: (keyword: string) => void; | ||
| } | ||
|
|
||
| const ConceptResult = ({ selectedKeywords, onRemove }: ConceptResultProps) => { | ||
| return ( | ||
| <div className="rounded-12 bg-gray-5 flex h-12.5 flex-row gap-8 px-4 py-2"> | ||
| <p className="text-gray-80 text-body1-m flex items-center">선택한 컨셉</p> | ||
| <div className="flex flex-row flex-wrap gap-2"> | ||
| {selectedKeywords.map(keyword => ( | ||
| <Chip | ||
| key={keyword} | ||
| label={keyword} | ||
| variant="removable" | ||
| onRemove={() => onRemove(keyword)} | ||
| /> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ConceptResult; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: Ditda-Official/Ditda-Frontend
Length of output: 50385
🏁 Script executed:
Repository: Ditda-Official/Ditda-Frontend
Length of output: 33087
src/features/instructor/write/ui/ConceptResult.tsx: 고정 높이는 제거하는 편이 안전합니다.
selectedKeywords가 최대 5개라 좁은 폭에서는 칩이 2줄로 래핑될 수 있는데, 현재h-12.5로 고정돼 있어 두 번째 줄이 박스 밖으로 밀려나 아래 영역과 겹칠 수 있습니다.min-h-12.5로 바꾸거나, 한 줄만 유지하려면flex-nowrap + overflow-x-auto로 맞춰주세요.🤖 Prompt for AI Agents