Skip to content

[BUG] 매칭 중 외주 조회 시 지원자 없으면 외주가 결과에서 누락됨#90

Merged
fervovita merged 1 commit into
devfrom
fix/#89-matching-commission-query
Jul 4, 2026
Merged

[BUG] 매칭 중 외주 조회 시 지원자 없으면 외주가 결과에서 누락됨#90
fervovita merged 1 commit into
devfrom
fix/#89-matching-commission-query

Conversation

@fervovita

Copy link
Copy Markdown
Collaborator

🚀 Related issue

Closes #89

#️⃣ Summary

  • 매칭 중 외주 조회(GET /api/v1/instructors/dashboards/matchings) 시 지원자 없으면 외주가 결과에서 누락되는 문제를 해결했습니다.

🔧 Changes

  • findMatchingViews JPQL에 LEFT JOIN a.designer d 추가
  • COUNT(DISTINCT a.designer.level) → COUNT(DISTINCT d.level)로 변경

📸 Test Evidence

image

💬 Reviewer Notes

Before After
Hibernate: 
    select
        c1_0.commission_id,
        c1_0.additional_concept,
        c1_0.application_deadline,
        c1_0.assigned_designer_id,
        c1_0.category_type,
        c1_0.color_selection_mode,
        c1_0.created_at,
        c1_0.final_deadline,
        c1_0.first_draft_deadline,
        c1_0.instructor_id,
        c1_0.max_revision,
        c1_0.size,
        c1_0.plan_code,
        c1_0.selected_at,
        c1_0.status,
        c1_0.title,
        c1_0.updated_at,
        count(distinct d1_0.level),
        count(ca1_0.commission_application_id) 
    from
        commissions c1_0 
    left join
        commission_applications ca1_0 
            on ca1_0.commission_id=c1_0.commission_id 
            and ca1_0.status=? 
    join
        designers d1_0 
            on d1_0.designer_id=ca1_0.designer_id 
    where
        c1_0.instructor_id=? 
        and c1_0.status=? 
    group by
        c1_0.commission_id 
    order by
        c1_0.application_deadline
Hibernate: 
    select
        c1_0.commission_id,
        c1_0.additional_concept,
        c1_0.application_deadline,
        c1_0.assigned_designer_id,
        c1_0.category_type,
        c1_0.color_selection_mode,
        c1_0.created_at,
        c1_0.final_deadline,
        c1_0.first_draft_deadline,
        c1_0.instructor_id,
        c1_0.max_revision,
        c1_0.size,
        c1_0.plan_code,
        c1_0.selected_at,
        c1_0.status,
        c1_0.title,
        c1_0.updated_at,
        count(distinct d1_0.level),
        count(ca1_0.commission_application_id) 
    from
        commissions c1_0 
    left join
        commission_applications ca1_0 
            on ca1_0.commission_id=c1_0.commission_id 
            and ca1_0.status=? 
    left join
        designers d1_0 
            on d1_0.designer_id=ca1_0.designer_id 
    where
        c1_0.instructor_id=? 
        and c1_0.status=? 
    group by
        c1_0.commission_id 
    order by
        c1_0.application_deadline

@fervovita fervovita self-assigned this Jul 3, 2026
@fervovita fervovita requested a review from Jong0128 as a code owner July 3, 2026 17:03
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fervovita, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 038a8e08-0af4-4b4a-99b1-1f9cf52c360e

📥 Commits

Reviewing files that changed from the base of the PR and between b7c6a49 and 750631d.

📒 Files selected for processing (1)
  • src/main/java/ditda/backend/domain/commission/dashboard/repository/DashboardCommissionRepository.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#89-matching-commission-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jong0128 Jong0128 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오..!! 이런 버그가 있었군요...
찾아줘서 감사합니다!! 바로 merge 해주셔도 좋을꺼같습니다 👍

@fervovita fervovita merged commit ba81caf into dev Jul 4, 2026
2 checks passed
@fervovita fervovita deleted the fix/#89-matching-commission-query branch July 4, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 매칭 중 외주 조회 시 지원자 없으면 외주가 결과에서 누락됨

2 participants