[BUG] 시안 제출 현황 조회 조건 수정

[fervovita]

🚀 Related issue

Closes #74

#️⃣ Summary

• 시안 제출 현황 조회(GET /api/v1/instructors/dashboards/draft-submissions)시 시안이 모두 제출된 상태(DRAFT_SELECTING)인 상태의 외주도 포함되도록 수정했습니다.

🔧 Changes

• 시안 제출 현황 조회시 DRAFT_SUBMITTING과 DRAFT_SELECTING를 조회하도록 변경

📸 Test Evidence

• swagger나 postman 결과를 캡쳐하여 첨부

💬 Reviewer Notes

• 리뷰어나 같이 작업하는 사람들에게 남길 코멘트

Summary by CodeRabbit

• 기능 개선

  • 시안 제출 현황 조회 범위가 확장되어, 더 많은 상태의 항목이 함께 표시됩니다.
  • 강의자 대시보드에서 시안 관련 목록이 이전보다 더 완전하게 집계됩니다.

• 버그 수정

  • 특정 상태만 포함되던 조회 조건을 보완해, 누락되던 항목이 조회에 반영되도록 개선했습니다.

[coderabbitai]

Warning

Review limit reached

@fervovita, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 54e95e02-60b5-48e2-b1c6-d99d81075265

📥 Commits

Reviewing files that changed from the base of the PR and between 61f4670 and e1217c2.

📒 Files selected for processing (1)

• src/main/java/ditda/backend/domain/commission/dashboard/repository/DashboardCommissionRepository.java

📝 Walkthrough

Walkthrough

DashboardCommissionRepository#findDraftSubmissionViews의 JPQL 파라미터와 메서드 시그니처를 단일 CommissionStatus에서 Set<CommissionStatus>로 변경하고, InstructorDashboardService#getDraftSubmissions에서 DRAFT_SUBMITTING과 DRAFT_SELECTING 두 상태를 함께 전달하도록 수정했습니다.

Changes

시안 제출 현황 조회 조건 확장

Layer / File(s)	Summary
Repository JPQL 파라미터 Set으로 변경 ...dashboard/repository/DashboardCommissionRepository.java	findDraftSubmissionViews 메서드 인자를 CommissionStatus 단일값에서 Set<CommissionStatus>로 변경하고, JPQL의 바인딩 파라미터명을 :commissionStatus → :commissionStatuses로 수정. java.util.Set import 추가.
Service 호출부 다중 상태 전달 ...dashboard/service/InstructorDashboardService.java	getDraftSubmissions에서 Set.of(CommissionStatus.DRAFT_SUBMITTING, CommissionStatus.DRAFT_SELECTING)를 repository에 전달하도록 변경. java.util.Set import 추가.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Ditda-Official/Ditda-Backend#22: CommissionStatus 및 외주/시안 워크플로우 도메인 엔티티를 추가해 이번 PR에서 사용하는 상태값의 기반을 제공.
• Ditda-Official/Ditda-Backend#40: 강사 대시보드 시안 제출 현황 조회 흐름을 도입한 PR로, 이번 변경의 직접적인 선행 작업.
• Ditda-Official/Ditda-Backend#58: CommissionStatus를 DRAFT_SUBMITTING/DRAFT_SELECTING으로 분리한 작업으로, 이번 필터 확장과 동일한 상태 정의 변경에 맞물림.

Suggested reviewers

• Jong0128

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	서비스는 두 상태를 전달하지만 저장소 쿼리가 컬렉션에 대한 = 비교로 보이며, 요구한 두 상태 조회를 보장하지 못합니다.	JPQL 조건을 c.status IN :commissionStatuses로 수정하고, DRAFT_SUBMITTING과 DRAFT_SELECTING이 함께 조회되는지 확인하세요.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목이 시안 제출 현황 조회 조건 수정이라는 핵심 변경을 간결하게 잘 요약합니다.
Out of Scope Changes check	✅ Passed	변경은 draft-submissions 조회 조건 확장과 그에 따른 저장소/서비스 수정으로만 이루어져 있습니다.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/#74-draft-submissions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/main/java/ditda/backend/domain/commission/dashboard/repository/DashboardCommissionRepository.java`:
- Line 24: The query in DashboardCommissionRepository is binding a
Set<CommissionStatus> with equality, which is incorrect for multiple statuses.
Update the repository query to use c.status IN :commissionStatuses instead of
c.status = :commissionStatuses, and make sure the method signature and parameter
name match the IN-based lookup so the status filter works correctly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9172ff00-4b48-4cee-90f8-53b4ee03d507

📥 Commits

Reviewing files that changed from the base of the PR and between 2e9c7c5 and 61f4670.

📒 Files selected for processing (2)

• src/main/java/ditda/backend/domain/commission/dashboard/repository/DashboardCommissionRepository.java
• src/main/java/ditda/backend/domain/commission/dashboard/service/InstructorDashboardService.java

[Jong0128]

바로 머지해도 좋을꺼같습니다!!
수고하셨습니다 👍