[WIP] Remove deprecated Matplotlib stem() parameter - Fixes #1314 #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use_line_collection parameter was removed in Matplotlib 3.6.0 as LineCollection became the only implementation for stem plots. This fixes the TypeError when using newer versions of Matplotlib. This commit requires updating the minimum Matplotlib version to 3.6.0 before it can be merged. Fixes #[1314]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a TypeError that occurs when using newer versions of Matplotlib
by removing the deprecated
use_line_collectionparameter from stem plots inthe regressor module.
Breaking Change⚠️
This change requires updating Yellowbrick's minimum Matplotlib dependency to
3.6.0 or later, as this version made LineCollection the only implementation
for stem plots.
TODO Before Merge
Testing Done
Related Issues
I'll remove the WIP tag once we've completed the Matplotlib version upgrade
across the entire package.