[MinGW] Add double quotes to OpenSSL Path in Makefile#193
Open
irisknowz wants to merge 1 commit intoDiscordMessenger:masterfrom
Open
[MinGW] Add double quotes to OpenSSL Path in Makefile#193irisknowz wants to merge 1 commit intoDiscordMessenger:masterfrom
irisknowz wants to merge 1 commit intoDiscordMessenger:masterfrom
Conversation
DiscordMessenger#193: Without the double quotes in the Makefile, a path with spaces in either OPENSSL_INC_DIR or OPENSSL_LIB_DIR would be interpreted as multiple arguments on the linker and it would fail. This commit fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the double quotes in the Makefile, a path with spaces in either OPENSSL_INC_DIR or OPENSSL_LIB_DIR would be interpreted as multiple arguments on the linker and it would fail. This pull request fixes that. It also adds two more messages showing the paths.
EXAMPLE SCREENSHOT:
I also believe we should move from this static Makefile to a ./configure.sh or a automake/autoconfig script, as users need too much interaction to make this.