Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated documentation #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fdac89
Update README.md
Joshuaharry120 Jul 31, 2020
32eb27b
Merge pull request #1 from Joshuaharry120/Joshuaharry120-some-documen…
Joshuaharry120 Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ looking. You've came to the right place.
this repository to show your love.

### Note
- If within your gitlab CI Code, you have a pause within the script code, this notiction yml code will still run, to fix this, we need to add allow_failure: false, this will mean the job will not run unless told to(see screenshot)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If within your gitlab CI Code, you have a pause within the script code, this notiction yml code will still run, to fix this, we need to add allow_failure: false, this will mean the job will not run unless told to(see screenshot)
- If you pause the GitLab CI build, `after_success` still gets triggered resulting in this webhook notification being fired. To work around this, we need to add `allow_failure: false` to the config (see screenshot).

Rephrased the sentence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see screenshot)

Did you forget to add the screenshot?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot not needed, as it will be different per CI setup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why is (see screenshot) added?


- If you face any issues in the scripts (and you're sure it's not on your side),
please consider opening an issue and I'll fix it ASAP.
- If you want to improve the scripts, feel free to open a pull request.
Expand Down