Test/vault expiry windows#922
Merged
1nonlypiece merged 7 commits intoJun 28, 2026
Merged
Conversation
…nbook docs: zero-downtime migration and indexing strategy runbook
…uthz security: re-authorize export downloads and enforce per-object org ow…
test: vault expiry deadline-window boundaries and DST safety
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| res.send(job.result) | ||
| }) | ||
|
|
||
| router.get('/:id/download', authenticate, async (req: AuthenticatedRequest, res: Response) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests in
src/tests/vaultExpiry.windows.test.tsto validate deadline-window boundary selection, UTC timestamp parsing, DST transitions, and idempotency deduplication forsendMilestoneReminders. Also fixes mock evaluation insrc/tests/vaultExpiry.reminders.test.ts.Key Verification Points Covered:
timeUntilDue === leadTimeMs) and inside lower boundaries (timeUntilDue === 1ms) are included, while exact deadline hits (timeUntilDue === 0ms), overdue items, and outside upper edges (timeUntilDue === leadTimeMs + 1ms) are excluded.docs/TIMEZONE_CONTRACT.mdguidelines and sub-second precision.milestone-reminder-{id}-{leadTimeMs}) and database unique constraint collision handling.Type of change
Related Issues
Closes #869