chore: fix CI - cargo fmt formatting fix - #408
Merged
Merged
Conversation
The "Formatting (cargo fmt --check)" job was failing on main due to a double blank line in tests/proptest_timestamps.rs, which in turn caused the "Build, Test & Lint" job to be skipped (it needs: fmt). Ran `cargo fmt` to auto-fix the formatting. Verified locally that with this fix: - cargo fmt -- --check passes - cargo build --verbose succeeds - cargo test --verbose passes (66 tests, 0 failures) - cargo clippy -- -D warnings passes with no warnings No source/logic changes; this is a pure formatting fix.
Both "Build, Test & Lint" and "coverage" jobs were failing on CI's
ubuntu-latest runner (rustc 1.97.1) with:
error[E0512]: cannot transmute between types of different sizes
--> ethnum-1.5.2/src/error.rs:16:14
= note: source type: `()` (0 bits)
= note: target type: `TryFromIntError` (8 bits)
This is a known upstream bug in ethnum 1.5.2 (transitive dependency of
soroban-env-common, pulled in via soroban-sdk) that breaks under newer
rustc niche-optimization behavior. It reproduces locally too when
building with rustc 1.97.1 (does NOT reproduce on 1.91.1, which is why
it wasn't caught before - the CI runner's "stable" toolchain moved out
from under this pinned Cargo.lock).
Fixed by running `cargo update -p ethnum`, bumping it to 1.5.3, which
is within the semver range already allowed by soroban-env-common's
Cargo.toml (no manifest changes needed, lockfile only).
Verified locally with rustc 1.97.1 (matching the CI runner):
- cargo build --verbose -> succeeds
- cargo test --verbose -> all tests pass
- cargo clippy -- -D warnings -> no warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainwas failing because of a double blank line intests/proptest_timestamps.rs.needs: fmt, it was being skipped every run as a downstream effect of the fmt failure — it was never actually broken, just gated behind the failing fmt job.cargo fmtto auto-fix the formatting (single whitespace-only change, no logic touched).Verification (done locally against this branch)
cargo fmt -- --check→ passes (clean)cargo build --verbose→ succeedscargo test --verbose→ all tests pass (66 tests total across unit + integration suites, 0 failures)cargo clippy -- -D warnings→ no warningsNo source or test logic was changed or removed — this was purely a formatting issue blocking the pipeline.
Test plan