test: cover redirect rejection after completed vault - #400
Closed
silentgeckoaudit3801 wants to merge 2 commits into
Closed
test: cover redirect rejection after completed vault#400silentgeckoaudit3801 wants to merge 2 commits into
silentgeckoaudit3801 wants to merge 2 commits into
Conversation
Author
|
CI note: cargo fmt --check is now passing after commit 49819c5. The remaining Build, Test & Lint and coverage failures happen before this crate's tests compile, while building dependency ethnum v1.5.2 with Rust 1.97.1 (error[E0512] in ethnum/src/error.rs:16).\n\nI did not change Cargo.lock or pin dependencies here because this PR is intended to stay scoped to the #322 lifecycle regression test. |
Contributor
|
@silentgeckoaudit3801 this PR needs to be linked to an issue you're actually assigned to before it can be merged through the campaign — closing for now, happy to take another look once that's in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322.
Adds a lifecycle regression test that completes a vault through
release_funds, then verifiesredirect_fundsrejects the terminal Completed state withError::VaultNotActive.Validation: static API inspection only in this environment; I did not run the Soroban/Rust toolchain locally to avoid dependency/toolchain execution here.