Skip to content

test: cover redirect rejection after completed vault - #400

Closed
silentgeckoaudit3801 wants to merge 2 commits into
Disciplr-Org:mainfrom
silentgeckoaudit3801:test/redirect-completed-vault-322
Closed

test: cover redirect rejection after completed vault#400
silentgeckoaudit3801 wants to merge 2 commits into
Disciplr-Org:mainfrom
silentgeckoaudit3801:test/redirect-completed-vault-322

Conversation

@silentgeckoaudit3801

Copy link
Copy Markdown

Fixes #322.

Adds a lifecycle regression test that completes a vault through release_funds, then verifies redirect_funds rejects the terminal Completed state with Error::VaultNotActive.

Validation: static API inspection only in this environment; I did not run the Soroban/Rust toolchain locally to avoid dependency/toolchain execution here.

@silentgeckoaudit3801

Copy link
Copy Markdown
Author

CI note: cargo fmt --check is now passing after commit 49819c5. The remaining Build, Test & Lint and coverage failures happen before this crate's tests compile, while building dependency ethnum v1.5.2 with Rust 1.97.1 (error[E0512] in ethnum/src/error.rs:16).\n\nI did not change Cargo.lock or pin dependencies here because this PR is intended to stay scoped to the #322 lifecycle regression test.

@1nonlypiece

Copy link
Copy Markdown
Contributor

@silentgeckoaudit3801 this PR needs to be linked to an issue you're actually assigned to before it can be merged through the campaign — closing for now, happy to take another look once that's in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No test verifies redirect_funds rejects a Completed-status vault with VaultNotActive

2 participants