Skip to content

test: cover validated redirect guard#248

Closed
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/redirect-validated-block-tests
Closed

test: cover validated redirect guard#248
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/redirect-validated-block-tests

Conversation

@dangelo352

Copy link
Copy Markdown

Closes #227

Summary

  • add lifecycle coverage for create → validate → pass deadline → rejected redirect
  • assert redirect_funds returns Error::NotAuthorized for a validated vault after the deadline
  • prove failure_destination remains unchanged and release_funds still pays success_destination
  • document the redirect guard invariant in TESTING_GUIDE.md
  • include the stable rustfmt cleanup for tests/proptest_timestamps.rs that CI expects

Validation

  • CARGO_TARGET_DIR=/tmp/disciplr-redirect-target cargo test test_validated_vault_cannot_redirect_after_deadline_and_can_release
  • CARGO_TARGET_DIR=/tmp/disciplr-redirect-target cargo test — all tests passed
  • git diff --check

@1nonlypiece

Copy link
Copy Markdown
Contributor

thanks for the work here — but our flow is that you need to be assigned to the issue before opening a PR for it. #227 isn't assigned to you, so i'm closing this as invalid for now. please claim #227 first (comment on the issue or grab it on the GrantFox board), then re-raise and we'll review right away. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add coverage for the milestone-validated-blocks-redirect path in redirect_funds

2 participants