test+docs: cover cancel vault refunds#247
Closed
dangelo352 wants to merge 2 commits into
Closed
Conversation
Contributor
|
thanks for jumping on this. #232 hasn't been assigned to you though, and we need the PR author claimed on the issue before review. closing as invalid for now — grab #232 on the board and raise it again. https://discord.gg/xvNAvMJf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232
Summary
cancel_vaultrefunds exactlyvault.amountto the creator and returns contract escrow to its pre-create balanceError::VaultNotActivevault_cancelledeventREADME_CANCEL_VAULT.mdandTESTING_GUIDE.mdto describe real Soroban token-transfer refund behavior instead of simulated balance storageValidation
cargo test test_cancel_vault— passedcargo test— passed, 69 tests total across unit/integration/property suitesgit diff --checkNotes
cargo fmtcompleted; stable rustfmt prints warnings that this repo'simports_granularityandgroup_importssettings are nightly-only.