fix(cli): queue file changes that arrive during builds instead of dropping them #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pping them Previously, when a file change event arrived while a build was in progress (i.e., client stage was not Success/Failed/Aborted), the event was logged and silently discarded. This caused issues with tools like stylance, tailwind watch, or sass --watch that generate output files in response to source file changes. The typical failure case: 1. User saves a .module.scss file 2. dx starts rebuilding 3. stylance CLI (watching the same file) regenerates stylance.css 4. dx receives the stylance.css change event but discards it 5. Build completes with stale CSS Now, file changes that arrive during a build are queued in a pending_file_changes vector and processed after the build completes.
fasterthanlime
commented
Nov 21, 2025
| if let Some(_patching) = | ||
| err.downcast_ref::<crate::build::PatchError>() | ||
| BuilderUpdate::BuildReady { bundle } => { | ||
| match bundle.mode { |
Contributor
Author
There was a problem hiding this comment.
Whoops, I guess Rust format was there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a file change event arrived while a build was in progress (i.e., client stage was not Success/Failed/Aborted), the event was logged and silently discarded. This caused issues with tools like stylance, tailwind watch, or sass --watch that generate output files in response to source file changes.
The typical failure case:
Now, file changes that arrive during a build are queued in a pending_file_changes vector and processed after the build completes.